Clean up old certificate leases #15420
Conversation
knative-prow
bot
added
size/S
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #15420 +/- ##
=======================================
Coverage ? 84.53%
=======================================
Files ? 219
Lines ? 13595
Branches ? 0
=======================================
Hits ? 11493
Misses ? 1734
Partials ? 368 ☔ View full report in Codecov by Sentry. |
| @@ -32,6 +32,11 @@ import ( | |||
| "knative.dev/pkg/system" | |||
| ) | |||
|
|
|||
| const ( | |||
| networkingCertificatesReconcilerLease = "controller.knative.dev.networking.pkg.certificates.reconciler.reconciler" | |||
There was a problem hiding this comment.
is this the full name or why do we have HasPrefix below?
There was a problem hiding this comment.
"controller" is the component - while the rest of the string is the package name & type
|
/lgtm |
|
@dprotaso: once the present PR merges, I will cherry-pick it on top of release-1.15 in a new PR and assign it to you. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: dprotaso, skonto The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@dprotaso: new pull request created: #15424 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
Proposed Changes