Support for multiple types of workloads #15529
Conversation
|
Welcome @chenzhiguo! It looks like this is your first PR to knative/serving 🎉 |
|
Hi @chenzhiguo. Thanks for your PR. I'm waiting for a knative member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
knative-prow
bot
added
needs-ok-to-test
|
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: chenzhiguo The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
chenzhiguo
changed the title
| @@ -372,5 +373,30 @@ func (ks *scaler) scale(ctx context.Context, pa *autoscalingv1alpha1.PodAutoscal | |||
| } | |||
|
|
|||
| logger.Infof("Scaling from %d to %d", currentScale, desiredScale) | |||
| return desiredScale, ks.applyScale(ctx, pa, desiredScale, ps) | |||
There was a problem hiding this comment.
It seems you still have func (ks *scaler) applyScale(ctx context.Context... left unused.
|
Hi @chenzhiguo, I think there should be a design doc for this type of change (as this PR seems part of a bigger set of changes). Knative does not pick up automatically a new kind for autoscaling. For example when a revision is reconciled we create a deployment and that is the only option right now. We have status reporting based on the deployment resource etc. cc @dprotaso |
| import ( | ||
| "context" | ||
| "fmt" | ||
| v1 "k8s.io/api/core/v1" |
There was a problem hiding this comment.
Needs a new line in between.
Fixes #15528
Release Note