Skip to content
This repository has been archived by the owner on Dec 15, 2021. It is now read-only.

Add StackOverflow Link to bottom of homepage #273

Open
omerbensaadon opened this issue Mar 23, 2021 · 4 comments
Open

Add StackOverflow Link to bottom of homepage #273

omerbensaadon opened this issue Mar 23, 2021 · 4 comments

Comments

@omerbensaadon
Copy link

Screen Shot 2021-03-23 at 9 43 20 AM

Would be great to add a link to StackOverflow at the bottom here...

Where would I PR this change?

CC: @RichieEscarez

@RichieEscarez
Copy link
Contributor

This is one of the dynamic template pages.

The new content would be added to this list in the config file:
https://github.com/knative/website/blob/main/config/_default/params.toml#L70

Do remember to test all screen sizes (I expect some word cut-off might happen when adding more to that row, which would require some tweaking).

@omerbensaadon
Copy link
Author

thanks @RichieEscarez I'll throw this on the To Do List

@omerbensaadon
Copy link
Author

@RichieEscarez wait I am confused...

What you linked me to doesn't look like it appears on the homepage...? I don't see any of the copy ("Interested in learning more, speaking to other contributors..." etc)

@RichieEscarez
Copy link
Contributor

Sorry, that is the footer for all other pages so you need to add/update the footer in both places.

Here is the main site index (it was moved to knative/website to also protect it from change since it had "marketing" language) https://github.com/knative/website/blob/main/content-override/en/_index.html

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants