Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

css classes need a prefix/namespace #527

Closed
mgaitan opened this issue Apr 24, 2017 · 5 comments
Closed

css classes need a prefix/namespace #527

mgaitan opened this issue Apr 24, 2017 · 5 comments

Comments

@mgaitan
Copy link
Contributor

mgaitan commented Apr 24, 2017

I've been updating sphinxcontrib-mermaid to render inline diagrams (instead of using mermaid-cli and include them as <img> tag). It works but looks weird with the default sphinx theme, because mermaid's css set the following:

.section {
  opacity: 0.2;
}

image

Isn't this class name too common? shouldn't mermaid set all its own css under a namespace .mermaid or name them with a prefix like .mermaid_section ?

mgaitan pushed a commit to mgaitan/sphinxcontrib-mermaid that referenced this issue Apr 24, 2017
@tylerlong
Copy link
Collaborator

I agree with you that it's an issue. Maybe we should change it to .mermad .section.

@sclarson
Copy link

sclarson commented Nov 8, 2017

#577 Should resolve this

@mgaitan
Copy link
Contributor Author

mgaitan commented Nov 8, 2017

🍻 !

@ip2k
Copy link

ip2k commented Nov 27, 2017

This bit me as well. I ended up needing to change the 4 sections in the JS where this is specified. I searched for Sequence Diagram variables and it's inside the block. Specifically, I changed:
*/\n.section { to */\n.mermaid .section { . This fixed the issue when embedding Mermaid charts in an MkDocs site. I had to make this edit to https://unpkg.com/[email protected]/dist/mermaid.js , so it looks like it's still an issue on the most-current release available from unpkg.

Thanks!

@tylerlong
Copy link
Collaborator

It has been fixed.

mgenereu pushed a commit to mgenereu/mermaid that referenced this issue Jun 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants