IE, local html, cssRules access is denied #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
IE, open html file directly from hard disk(insead of from a http server), cssRules access is denied.
Thus an expection is thrown. But in the catch statement, another one is thrown again thus caused the whole mermaid code break.
In this line `console.warn('Invalid CSS selector "' + rule.selectorText + '"', err);` rule is undefined, so exception will be thrown if we don't check.
|
Thanks! Good catch! |
knsv
added a commit
that referenced
this pull request
Apr 19, 2015
IE, local html, cssRules access is denied
mgenereu
pushed a commit
to mgenereu/mermaid
that referenced
this pull request
Jun 25, 2022
…yarn/url-parse-1.5.1 Bump url-parse from 1.4.7 to 1.5.1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
IE, open html file directly from hard disk(insead of from a http server), cssRules access is denied.
Thus an expection is thrown. But in the catch statement, another one is thrown again thus cause the whole mermaid code break.
In this line
console.warn('Invalid CSS selector "' + rule.selectorText + '"', err);rule is undefined, so exception will be thrown if we don't check.