Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate npm dependencies: d3 and he #223

Merged
merged 1 commit into from
Oct 15, 2015
Merged

Remove duplicate npm dependencies: d3 and he #223

merged 1 commit into from
Oct 15, 2015
+0 −2

Conversation

spect88
Copy link
Collaborator

@spect88 spect88 commented Oct 14, 2015

Hi,

This is just a tiny fix for:

npm WARN package.json Dependency 'd3' exists in both dependencies and devDependencies, using 'd3@~3.4.13' from dependencies
npm WARN package.json Dependency 'he' exists in both dependencies and devDependencies, using 'he@^0.5.0' from dependencies

@spect88
Remove duplicate npm dependencies: d3 and he
7e9e9cc 
These are already defined as dependencies (same versions), so there's
no point keeping them as devDependencies. npm complains about that.
knsv added a commit that referenced this pull request Oct 15, 2015
@knsv
Merge pull request #223 from spect88/remove-duplicate-dependencies
ae73583 
Remove duplicate npm dependencies: d3 and he
@knsv knsv merged commit ae73583 into mermaid-js:master Oct 15, 2015
@knsv
Copy link
Collaborator

knsv commented Oct 15, 2015

Thanks! Good with some cleaning. Will do a bigger dependency exercise soon.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@spect88 @knsv