Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SequenceDiagram: Add support for multiple alt else statements #641

Merged
merged 5 commits into from
Mar 16, 2018

Conversation

sechel
Copy link
Contributor

@sechel sechel commented Mar 15, 2018

We added support for multiple else statements, see also #348

@coveralls
Copy link

Pull Request Test Coverage Report for Build 652

  • 23 of 23 (100.0%) changed or added relevant lines in 1 file are covered.
  • No unchanged relevant lines lost coverage.
  • Overall coverage increased (+0.008%) to 54.176%

Totals Coverage Status
Change from base Build 651: 0.008%
Covered Lines: 2046
Relevant Lines: 3750

💛 - Coveralls

@tylerlong
Copy link
Collaborator

It looks great! I will review it carefully. Please give me 1-3 days.

Thank you so much for your contribution!

@sechel
Copy link
Contributor Author

sechel commented Mar 15, 2018

@tylerlong Codeclimate seems to complain about the Jison auto generated syntax parser for sequence diagrams. Not sure if this is something I introduced, though.

@tylerlong
Copy link
Collaborator

@sechel I believe I have removed codeclimate from this project. LoL For now you can safely ignore it. :)

@tylerlong tylerlong merged commit 93201b2 into mermaid-js:master Mar 16, 2018
mgenereu pushed a commit to mgenereu/mermaid that referenced this pull request Jun 25, 2022
…yarn/develop/monaco-editor-0.32.1

chore(deps): bump monaco-editor from 0.32.0 to 0.32.1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants