-
-
Notifications
You must be signed in to change notification settings - Fork 6.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding trapezoid and inverse trapezoid vertex options. #741
Conversation
Pull Request Test Coverage Report for Build 788
💛 - Coveralls |
Hi @adamwulf ! Thanks for this PR and I am sorry for the slow response. We are trying to expand the team to get a more steady pace. I think this PR is worthwhile and I would like to merge it but... there a few conflicts. If you take a pull from master and resolve the conflicts I would gladly merge. One more thing though... It would make a shorter syntax with
instad of
Is there a reason for the use of [ ] in the vertex? |
Awesome! I'll look into fixing the conflicts and post back when done. For the syntax, I'll try and change that as well. The reason it for the brackets is that the slashes are also part of |
Thx! I have now merged your contribution and trapezoids are now supported in mermaid. Could you also add some examples in the docs so that people will know how to use them? |
Just posted a pull request to mermaidjs/mermaid-gitbook#49 :) |
I added new vertex types for the flowchart - a trapezoid and upside-down trapezoid.
The syntax for the new vertex is:
The syntax isn't great, I had initially wanted it to be
A /text here\
but since the slashes are also part of punctuation and text it caused some issues when building the parser. Maybe there's better options though.