From 923ed1e171103475e40cf4d981b0202fa50ea597 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Wed, 30 Oct 2024 17:24:42 +0200 Subject: [PATCH 01/15] chore: add CODEOWNERS file --- .github/CODEOWNERS | 75 ++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed, 75 insertions(+) create mode 100644 .github/CODEOWNERS diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS new file mode 100644 index 0000000000..bd75e86634 --- /dev/null +++ b/.github/CODEOWNERS @@ -0,0 +1,75 @@ +# This is a comment. +# Each line is a file pattern followed by one or more owners. +# Last matching entry wins. + +# Default owner for all missed or newly added files. +* @magicznyleszek @noliveleger + + + + +#### Global section. +.editorconfig @magicznyleszek @noliveleger +.git-blame-ingore-revs @magicznyleszek @noliveleger +.gitattributes @magicznyleszek @noliveleger +.gitignore @magicznyleszek @noliveleger +.gitmodules @magicznyleszek @noliveleger +CONTRIBUTING.md @magicznyleszek @noliveleger +dependabot.yml @magicznyleszek @noliveleger +dependabot.yml @magicznyleszek @noliveleger +kpi.code-workspace @magicznyleszek @noliveleger +LICENSE @magicznyleszek @noliveleger +README.md @magicznyleszek @noliveleger + + + + +#### Frontend section. + +# Default owner +.storybook/* @magicznyleszek +cypress/* @magicznyleszek +jsapp/* @magicznyleszek +patches/* @magicznyleszek +static/* @magicznyleszek +webpack/* @magicznyleszek +.babelrc.json @magicznyleszek +.browserlistrc @magicznyleszek +.eslintignore @magicznyleszek +.eslintrc.js @magicznyleszek +.node-version @magicznyleszek +.nvmrc @magicznyleszek +.prettierrc.js @magicznyleszek +.stylelintrc.js @magicznyleszek +.swcrc @magicznyleszek +.coffeelnt.json @magicznyleszek +package-lock.json @magicznyleszek +package.json @magicznyleszek +tsconfig.json @magicznyleszek + +# Billing +/jsapp/js/account/* @jamesrkiger +/jsapp/js/components/usageLimits @jamesrkiger + + + + +#### Backend section + +# Default owner +.tx/* @noliveleger +dependencies/* @noliveleger +docker/* @noliveleger +hub/* @noliveleger +kobo/* @noliveleger +kpi/* @noliveleger +scripts/* @noliveleger +test/* @noliveleger +.coveragerc @noliveleger +.dockerignore @noliveleger +.gitlab-ci.yml @noliveleger +Dockerfile @noliveleger +format-python.sh @noliveleger +manage.py @noliveleger +pip-compile.sh @noliveleger +pyproject.toml @noliveleger From c6168ca84be34e9480520e1a71bca104a6a508a9 Mon Sep 17 00:00:00 2001 From: Rebecca Graber Date: Wed, 30 Oct 2024 12:10:15 -0400 Subject: [PATCH 02/15] fixup!: add rgraber as owner of audit logs --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index bd75e86634..dc161a8adb 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -62,6 +62,7 @@ dependencies/* @noliveleger docker/* @noliveleger hub/* @noliveleger kobo/* @noliveleger +kobo/apps/audit_log/* @rgraber kpi/* @noliveleger scripts/* @noliveleger test/* @noliveleger From 7a2349581c3bc2f70db894d4f51cd74236bce13e Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Olivier=20L=C3=A9ger?= Date: Thu, 31 Oct 2024 09:32:48 -0400 Subject: [PATCH 03/15] Update CODEOWNERS Remove my name from files I never touched, added @bufke, @jnm and @JacquelineMorrissette for files they should own. --- .github/CODEOWNERS | 43 +++++++++++++++++++++---------------------- 1 file changed, 21 insertions(+), 22 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index dc161a8adb..3def2d5b32 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -9,16 +9,15 @@ #### Global section. -.editorconfig @magicznyleszek @noliveleger -.git-blame-ingore-revs @magicznyleszek @noliveleger +.editorconfig @magicznyleszek +.git-blame-ignore-revs @magicznyleszek .gitattributes @magicznyleszek @noliveleger .gitignore @magicznyleszek @noliveleger .gitmodules @magicznyleszek @noliveleger -CONTRIBUTING.md @magicznyleszek @noliveleger -dependabot.yml @magicznyleszek @noliveleger -dependabot.yml @magicznyleszek @noliveleger -kpi.code-workspace @magicznyleszek @noliveleger -LICENSE @magicznyleszek @noliveleger +CONTRIBUTING.md @magicznyleszek +dependabot.yml @magicznyleszek +kpi.code-workspace @magicznyleszek +LICENSE @magicznyleszek @noliveleger @jnm README.md @magicznyleszek @noliveleger @@ -57,20 +56,20 @@ tsconfig.json @magicznyleszek #### Backend section # Default owner -.tx/* @noliveleger -dependencies/* @noliveleger -docker/* @noliveleger -hub/* @noliveleger -kobo/* @noliveleger +.tx/* @noliveleger @jnm @JacquelineMorrissette +dependencies/* @jnm @noliveleger +docker/* @jnm @noliveleger +hub/* @jnm @noliveleger +kobo/* @jnm @noliveleger kobo/apps/audit_log/* @rgraber -kpi/* @noliveleger -scripts/* @noliveleger -test/* @noliveleger -.coveragerc @noliveleger -.dockerignore @noliveleger -.gitlab-ci.yml @noliveleger -Dockerfile @noliveleger +kpi/* @jnm @noliveleger +scripts/* @noliveleger @jnm +test/* @jnm @noliveleger +.coveragerc @jnm +.dockerignore @noliveleger @jnm +.gitlab-ci.yml @bufke +Dockerfile @noliveleger @jnm @bufke format-python.sh @noliveleger -manage.py @noliveleger -pip-compile.sh @noliveleger -pyproject.toml @noliveleger +manage.py @noliveleger @jnm +pip-compile.sh @noliveleger @jnm +pyproject.toml @bufke From da7df7c9d865e7e7cfeeb6b5160187f49f1fe631 Mon Sep 17 00:00:00 2001 From: David Burke Date: Fri, 1 Nov 2024 10:35:52 -0400 Subject: [PATCH 04/15] Add bufke to docker and scripts dir --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 3def2d5b32..70ac94d34c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -58,12 +58,12 @@ tsconfig.json @magicznyleszek # Default owner .tx/* @noliveleger @jnm @JacquelineMorrissette dependencies/* @jnm @noliveleger -docker/* @jnm @noliveleger +docker/* @jnm @noliveleger @bufke hub/* @jnm @noliveleger kobo/* @jnm @noliveleger kobo/apps/audit_log/* @rgraber kpi/* @jnm @noliveleger -scripts/* @noliveleger @jnm +scripts/* @noliveleger @jnm @bufke test/* @jnm @noliveleger .coveragerc @jnm .dockerignore @noliveleger @jnm From 18880492ca46914d101ba45c62ec37234f3dcd28 Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 13:01:05 -0400 Subject: [PATCH 05/15] Assign pyproject.toml ownership to backend team --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 70ac94d34c..5b9302beb9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -72,4 +72,4 @@ Dockerfile @noliveleger @jnm @bufke format-python.sh @noliveleger manage.py @noliveleger @jnm pip-compile.sh @noliveleger @jnm -pyproject.toml @bufke +pyproject.toml @noliveleger @jnm From 091c5da43cb421748b2b227ac3bbd263a9d6acba Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 13:03:14 -0400 Subject: [PATCH 06/15] Assign translations-related ownership to Jackie MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …and John, and group these entries together --- .github/CODEOWNERS | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5b9302beb9..c2fdbca1b5 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -13,13 +13,16 @@ .git-blame-ignore-revs @magicznyleszek .gitattributes @magicznyleszek @noliveleger .gitignore @magicznyleszek @noliveleger -.gitmodules @magicznyleszek @noliveleger CONTRIBUTING.md @magicznyleszek dependabot.yml @magicznyleszek kpi.code-workspace @magicznyleszek LICENSE @magicznyleszek @noliveleger @jnm README.md @magicznyleszek @noliveleger +# Translations +.gitmodules @JacquelineMorrissette @jnm +.tx/* @JacquelineMorrissette @jnm + @@ -56,7 +59,6 @@ tsconfig.json @magicznyleszek #### Backend section # Default owner -.tx/* @noliveleger @jnm @JacquelineMorrissette dependencies/* @jnm @noliveleger docker/* @jnm @noliveleger @bufke hub/* @jnm @noliveleger From b3d7252f2e8e9a50e821d487c806fa46059cdd8f Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 13:06:35 -0400 Subject: [PATCH 07/15] Assign ownership to Olivier based on his role MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit …as the backend lead developer. `CONTRIBUTING.md` applies equally to the backend, and `kpi.code-workspace` contains various settings related to formatting and linting Python code --- .github/CODEOWNERS | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index c2fdbca1b5..220d1cbd7d 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -13,11 +13,11 @@ .git-blame-ignore-revs @magicznyleszek .gitattributes @magicznyleszek @noliveleger .gitignore @magicznyleszek @noliveleger -CONTRIBUTING.md @magicznyleszek +CONTRIBUTING.md @magicznyleszek @noliveleger dependabot.yml @magicznyleszek -kpi.code-workspace @magicznyleszek LICENSE @magicznyleszek @noliveleger @jnm README.md @magicznyleszek @noliveleger +kpi.code-workspace @magicznyleszek @noliveleger # Translations .gitmodules @JacquelineMorrissette @jnm From 49f68fecad5a79a2be02abb64e76b9c3b5a56816 Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 13:09:34 -0400 Subject: [PATCH 08/15] Add John to owners of README --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 220d1cbd7d..983c36dabd 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -16,8 +16,8 @@ CONTRIBUTING.md @magicznyleszek @noliveleger dependabot.yml @magicznyleszek LICENSE @magicznyleszek @noliveleger @jnm -README.md @magicznyleszek @noliveleger kpi.code-workspace @magicznyleszek @noliveleger +README.md @magicznyleszek @noliveleger @jnm # Translations .gitmodules @JacquelineMorrissette @jnm From 6fbcd3b77ccd4c04ceb31ffa8983e7cbfa8dbdfd Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 13:09:44 -0400 Subject: [PATCH 09/15] Assign ownership of LICENSE to John and Tino --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 983c36dabd..e04229e29b 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -15,8 +15,8 @@ .gitignore @magicznyleszek @noliveleger CONTRIBUTING.md @magicznyleszek @noliveleger dependabot.yml @magicznyleszek -LICENSE @magicznyleszek @noliveleger @jnm kpi.code-workspace @magicznyleszek @noliveleger +LICENSE @jnm @tinok README.md @magicznyleszek @noliveleger @jnm # Translations From c276eb0ef90d2b2b1f114a646d7c879bdef299d6 Mon Sep 17 00:00:00 2001 From: "John N. Milner" Date: Fri, 1 Nov 2024 15:37:49 -0400 Subject: [PATCH 10/15] Make Phil own VS Code config --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e04229e29b..2da6e29864 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -15,7 +15,7 @@ .gitignore @magicznyleszek @noliveleger CONTRIBUTING.md @magicznyleszek @noliveleger dependabot.yml @magicznyleszek -kpi.code-workspace @magicznyleszek @noliveleger +kpi.code-workspace @p2edwards LICENSE @jnm @tinok README.md @magicznyleszek @noliveleger @jnm From 126f7c29af75df23d2400fa578c00e5b1a384db9 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Sat, 2 Nov 2024 12:24:14 +0200 Subject: [PATCH 11/15] style(CODEOWNERS): sort and group --- .github/CODEOWNERS | 43 ++++++++++++++++++++++++++++--------------- 1 file changed, 28 insertions(+), 15 deletions(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 2da6e29864..5c38c6c1d4 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,13 +1,16 @@ -# This is a comment. -# Each line is a file pattern followed by one or more owners. -# Last matching entry wins. +## This is a comment. +## Each line is a file pattern followed by one or more owners. +## Last matching entry wins. + + -# Default owner for all missed or newly added files. -* @magicznyleszek @noliveleger +## Default owner for all missed or newly added files. +* @magicznyleszek @noliveleger +################ #### Global section. .editorconfig @magicznyleszek .git-blame-ignore-revs @magicznyleszek @@ -17,15 +20,16 @@ CONTRIBUTING.md @magicznyleszek @noliveleger dependabot.yml @magicznyleszek kpi.code-workspace @p2edwards LICENSE @jnm @tinok -README.md @magicznyleszek @noliveleger @jnm +README.md @jnm @magicznyleszek @noliveleger -# Translations +## Translations .gitmodules @JacquelineMorrissette @jnm .tx/* @JacquelineMorrissette @jnm +################ #### Frontend section. # Default owner @@ -56,22 +60,31 @@ tsconfig.json @magicznyleszek +################ #### Backend section # Default owner dependencies/* @jnm @noliveleger -docker/* @jnm @noliveleger @bufke hub/* @jnm @noliveleger kobo/* @jnm @noliveleger kobo/apps/audit_log/* @rgraber kpi/* @jnm @noliveleger -scripts/* @noliveleger @jnm @bufke test/* @jnm @noliveleger .coveragerc @jnm -.dockerignore @noliveleger @jnm -.gitlab-ci.yml @bufke -Dockerfile @noliveleger @jnm @bufke +.dockerignore @jnm @noliveleger format-python.sh @noliveleger -manage.py @noliveleger @jnm -pip-compile.sh @noliveleger @jnm -pyproject.toml @noliveleger @jnm +manage.py @jnm @noliveleger +pip-compile.sh @jnm @noliveleger +pyproject.toml @jnm @noliveleger + + + + +################ +#### Infra section + +docker/* @bufke @jnm @noliveleger +scripts/* @bufke @jnm @noliveleger +.gitlab-ci.yml @bufke +Dockerfile @bufke @jnm @noliveleger + From 8c679b87ee6e67923718b9978ab9a32da19f4def Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Sat, 2 Nov 2024 12:24:35 +0200 Subject: [PATCH 12/15] docs(CODEOWNERS): clarify last line wins --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 5c38c6c1d4..cf11a86e60 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -1,6 +1,6 @@ ## This is a comment. ## Each line is a file pattern followed by one or more owners. -## Last matching entry wins. +## Last matching line wins. From 2281230a9b95d682c6eabbacc91d94ca89f68f65 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Sat, 2 Nov 2024 12:25:20 +0200 Subject: [PATCH 13/15] chore(CODEOWNERS): patches for phil --- .github/CODEOWNERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index cf11a86e60..1a9b0a37e9 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -36,7 +36,7 @@ README.md @jnm @magicznyleszek @noliveleger .storybook/* @magicznyleszek cypress/* @magicznyleszek jsapp/* @magicznyleszek -patches/* @magicznyleszek +patches/* @p2edwards static/* @magicznyleszek webpack/* @magicznyleszek .babelrc.json @magicznyleszek From d26bb8d760e3cbf2dd0ad45ac76773b8f68330af Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Kalvis=20Kalni=C5=86=C5=A1?= Date: Sat, 2 Nov 2024 12:29:24 +0200 Subject: [PATCH 14/15] chore(CODEOWNERS): add github folder --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index 1a9b0a37e9..e8d45f966c 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -85,6 +85,7 @@ pyproject.toml @jnm @noliveleger docker/* @bufke @jnm @noliveleger scripts/* @bufke @jnm @noliveleger +.github/* @bufke @jnm @noliveleger @magicznyleszek .gitlab-ci.yml @bufke Dockerfile @bufke @jnm @noliveleger From 66ce70bf3de7a7bf2f90da76578165ef864c46c1 Mon Sep 17 00:00:00 2001 From: Guillermo Date: Mon, 4 Nov 2024 01:40:06 -0600 Subject: [PATCH 15/15] Update code owners --- .github/CODEOWNERS | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/CODEOWNERS b/.github/CODEOWNERS index e8d45f966c..207d44b3ac 100644 --- a/.github/CODEOWNERS +++ b/.github/CODEOWNERS @@ -68,6 +68,7 @@ dependencies/* @jnm @noliveleger hub/* @jnm @noliveleger kobo/* @jnm @noliveleger kobo/apps/audit_log/* @rgraber +kobo/apps/subsequences/* @Guitlle kpi/* @jnm @noliveleger test/* @jnm @noliveleger .coveragerc @jnm