Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update dacite dependency #2

Closed
christianvaes opened this issue Sep 13, 2024 · 6 comments
Closed

update dacite dependency #2

christianvaes opened this issue Sep 13, 2024 · 6 comments
Assignees
Labels
bug Something isn't working good first issue Good for newcomers

Comments

@christianvaes
Copy link

Hi,

Every time I install an update of the Eplucon integration(using HACS) the Roborock integration stops working with the following error:

File "/usr/local/lib/python3.12/site-packages/roborock/containers.py", line 112, in from_dict raise RoborockException("It seems like you have an outdated version of dacite.") from err roborock.exceptions.RoborockException: It seems like you have an outdated version of dacite.

This seems to be caused by an old version of the python package 'dacite' used in this integration which overrides the default one of home assistant. Is there a possibility to update the dacite package used in this integration to the latest version?

@koenhendriks
Copy link
Owner

Hmm I did not specify any version in my requirements.txt thinking this would mean the latest stable release., but I guess that's not how python dependencies are managed.

I'll take a look if I can enforce the latest dacite version and see if everything is still stable. That should fix this issue (assuming that the Roborock extension is actually on the latest).

@koenhendriks koenhendriks self-assigned this Sep 16, 2024
@koenhendriks koenhendriks added bug Something isn't working good first issue Good for newcomers labels Sep 16, 2024
@koenhendriks
Copy link
Owner

I've tried updating it to be dacite==1.8.1 but I don't think that's going to fix the issue as I get the message Requirement already satisfied: dacite==1.8.1

Maybe the issue is with Roborock?

@christianvaes
Copy link
Author

I thought that as well first, but then found home-assistant/core#122411 this mentions that another integration(Govee) downgrades the dacite dependency and causes the issue. After they removed that integration the roborock integration start to work. But since I don't have this govee integration I searched which integration used the dacite dependency aswell. This turned out to be eplucon integration. After that I tried to fix it. One weird thing is that when I try to click "download again" for the eplucon integration detail page in hacs and restart home assistant both integration start to work again and the error is gone. However after some restarts it comes up again. That's why I thought it's related to the dependencies of Eplucon which override the default dacite from Home assistant. For that reason I made this issue as it looks like that eplucon integration is impacting the dacite dependency (sometimes) somehow.

Do you have another idea based on above explanation?

@koenhendriks
Copy link
Owner

I'll try dacite>=1.8.1,<2.0.0 for the next release. That should cover any future update until the next major release.

@koenhendriks
Copy link
Owner

I've released v1.2.2 with this update. Let me know if this fixes it. If not, I'm afraid there is not much more I can do on the problem.

@christianvaes
Copy link
Author

I installed the new version, atleast the initial restart was without issues(previously this went wrong many times). Will keep an eye on this and report back.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants