Skip to content

Latest commit

 

History

History
67 lines (45 loc) · 2.78 KB

CONTRIBUTING.md

File metadata and controls

67 lines (45 loc) · 2.78 KB

Contributing

Wrangler is an open source project because we believe that folks should have access, insight, and the opportunity to contribute to their developer tools. Wrangler is also a product delivered by Cloudflare, so it's important to clarify how we think about issue triage and contributions.

People

Wrangler is maintained by @ashleygwilliams, and her team, Workers Developer Experience.

Primary Issue Triage

Within 3 days, any incoming issue should be triaged. Triage involves:

  • reading the issue and requesting any further information
  • always thank the user for submitting

Labelling

  • label all issues coming from non-team members with user report
  • labelling the category of the issue: feature, external bug, bug, maintenance, docs, refactor, release
  • labelling the status of the issue: needs design, needs docs, needs more info, needs repro, needs template, PR attached, PR welcome, waiting on response
  • optionally labelling a subject: cargo install, kv, routes, site, webpack, workers runtime
  • optionally labelling other calls to action: help wanted, question, good first issue

Assignment

  • if the issue will require a large amount of back and forth between the reporter and the team assign a single team member to manage the conversation

Product Issue Triage

Once a week, the team meets to do Product Triage. This is where we assign work and update our plans for the milestones and releases.

Labelling

  • labelling the priority of the issue: critical, nice to have, low priority
  • labelling the status of the issue: Needs Design, PR Welcome

Assignment and Milestones

  • assign all issues for the next two releases a milestone
  • assign all issues for the current milestone a person to take point

Pull Request Triage

Within 3 days, all incoming Community PRs should be triaged. If a team member opens a PR it should be triaged immediately upon open by the PR author.

Labelling

  • All work-in-progress PRs should be labelled work in progress and the title should be annotated [WIP] for easy scanning. No WIP PRs will be reviewed until the annotations are removed.
  • All PRs that need to be reviewed should be labelled needs review until they have received all required reviews.
  • All PRs should be labelled with a changelog label: BREAKING, feature, fix, maintenance, docs

Merging

  • All PRs should be merged with a Merge Commit. We recommend that folks rebase into a small number of task driven commits. This is enforced more heavily for team members than community members. Be reasonable.
  • All PRs should be labelled with the current milestone before merging. If a PR for an issue labelled with a different milestone is to be merged, update the issue milestone as well.