Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always save network module type to metadata #254

Open
space-nuko opened this issue Mar 4, 2023 · 4 comments
Open

Always save network module type to metadata #254

space-nuko opened this issue Mar 4, 2023 · 4 comments

Comments

@space-nuko
Copy link
Contributor

I'm thinking it would be a good idea to always save the network module type to the metadata because that allows the models list in additional_networks to be filtered based on that metadata. Without it it's too easy to choose a non-locon model

@kohya-ss
Copy link
Owner

kohya-ss commented Mar 6, 2023

I think the metadata already has ss_network_module. Its value is like networks.lora.

Is this sufficient for filtering?

@space-nuko
Copy link
Contributor Author

I mean to say to save it even if --no-metadata is passed on the command line. In practice some of the metadata like sshs_model_hash is useful for the additional_networks indexer also

@kohya-ss
Copy link
Owner

kohya-ss commented Mar 7, 2023

I got it! I will save ss_network_module, ss_network_dim, ss_network_alpha and ss_network_args. These values can be determined the weights itself, it is not a problem if the metadata contains them.

@kohya-ss
Copy link
Owner

kohya-ss commented Mar 9, 2023

Now minimum metadata is recorded. I will also work on the merged/extracted models.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants