New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Visual testing #41

Open

3 tasks

kokes opened this issue Feb 8, 2020 · 1 comment

Owner

kokes commented Feb 8, 2020

Since it's quite hard to build proper tests (see #33), we can start by having non-automated visual tests. What I envisage the workflow to be:

Take screenshots of various notebooks in nbviewer.js
Work on whatever changes you want
Take the same screenshots again
Use something like pixelmatch to diff these

What we need in terms of infrastructure:

sample notebooks, versioned
a way to offer inject a notebook into the viewer (maybe we'll have a separate HTML file for testing, without the dropzone stuff)
some code to automate the screenshot taking and diffing

Owner Author

kokes commented Feb 8, 2020

wip: https://github.com/kokes/nbviewer.js/tree/issue41

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment