Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI is not testing OpenMP space #67

Open
Matthew-Whitlock opened this issue Jun 21, 2024 · 0 comments
Open

CI is not testing OpenMP space #67

Matthew-Whitlock opened this issue Jun 21, 2024 · 0 comments
Labels

Comments

@Matthew-Whitlock
Copy link
Collaborator

Matthew-Whitlock commented Jun 21, 2024

We need to add +openmp to the kokkos spack. Since Kokkos doesn't have OpenMP we silently don't build the OpenMP space.

We could probably change the exec space variables to use KR_*_DEVICE_ENABLED as the default value instead of as a dependency, so builds fail when spaces are requested but can't be built.

@nmm0 nmm0 added the CI label Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants