Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid repeated downloads of the same Helm version #3

Open
kiwi-oss opened this issue Mar 4, 2021 · 4 comments
Open

Avoid repeated downloads of the same Helm version #3

kiwi-oss opened this issue Mar 4, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@kiwi-oss
Copy link
Contributor

kiwi-oss commented Mar 4, 2021

Helm is downloaded in the same version every time a task from this plugin is used.

Would it be possible to cache a given version to avoid unnecessary downloads?

@jekkel
Copy link
Contributor

jekkel commented Mar 4, 2021

The downloaded file should be a cached build artifact which only gets downloaded again if something changes. Do 2 consecutive executions of e.g. helmChartBuild (without clean in between) trigger download twice? Could you provide a reproducer project?

@kiwi-oss
Copy link
Contributor Author

kiwi-oss commented Mar 9, 2021

Sorry, I forgot to provide the information that I executed clean in-between. The download is indeed only triggered then.

However, that's unexpected for me because I see the Helm binary more as a build dependency rather than a build artefact.

So just like cleaning doesn't cause dependencies to be re-fetched, I thought it wouldn't do so with the Helm binary either.

One could also see it as a build tool similar to the Gradle binary downloaded by the Gradle wrapper. It's also not influenced by the clean task because these things don't change often and fetching is relatively time-consuming.

@jekkel
Copy link
Contributor

jekkel commented Mar 9, 2021

That's a nice viewpoint indeed. Would love to see a PR where helm binary is made a dependency, maybe by using tweaked ivy dependency? Then we would use the resolved dependency as input to the tasks instead and let gradle download the binary.

@kiwi-oss
Copy link
Contributor Author

kiwi-oss commented Mar 9, 2021

Thanks for the pointer, I'll see what I can do.

@jekkel jekkel added the enhancement New feature or request label Mar 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Development

No branches or pull requests

2 participants