Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

React video is not muted #17

Closed
komlevv opened this issue Aug 1, 2022 · 3 comments
Closed

React video is not muted #17

komlevv opened this issue Aug 1, 2022 · 3 comments
Labels
Priority: Low
Milestone
TBD

Comments

@komlevv
Copy link
Owner

komlevv commented Aug 1, 2022 •
edited
Loading

facebook/react#10389
SO discussion
React doesn't set muted attribute. Videos without muted won't autoplay on mobile
Investigate before release
@komlevv komlevv added this to the Release-1.0 milestone Aug 1, 2022
@komlevv
Copy link
Owner Author

komlevv commented Aug 5, 2022

db727e2 temporary fix, leaving this open until fixed in React

@komlevv komlevv modified the milestones: Release-1.0, TBD Aug 5, 2022
@komlevv
Copy link
Owner Author

komlevv commented Oct 2, 2022 •
edited
Loading

Need to test if injecting muted attr works on mobile and close. From the relevant discussion in upstream this prob won't be fixed.

@komlevv
Copy link
Owner Author

komlevv commented Oct 9, 2022

Manually injecting the attribute seems to work on mobile, so closing for now

@komlevv komlevv closed this as completed Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Priority: Low
Projects
None yet
Milestone
TBD
Development

No branches or pull requests
1 participant
@komlevv