New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support `diagnostic_events_xdr` field in SendTransactionResponse struct #146

Merged

miguelnietoa merged 1 commit into v0.19 from support-new-field-in-send-transaction-response

Jan 31, 2024

Member

miguelnietoa commented Jan 31, 2024

Description

This PR added the diagnostic_events_xdr field in SendTransactionResponse struct.

Fixes Add support for new fields in Soroban RPC's sendTransaction endpoint stellar_sdk#350

Type of change

New feature (non-breaking change which adds functionality)

Checklist

My code follows the style guidelines of this project
I have performed a self-review of my code
I have commented on my code, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
My changes generate no new warnings
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes


          Support 'diagnostic_events_xdr' field in SendTransactionResponse struct

a3ef7df

miguelnietoa requested a review from CristhianRodriguezMolina

January 31, 2024 20:49

CristhianRodriguezMolina approved these changes

View reviewed changes

Contributor

CristhianRodriguezMolina left a comment

LGTM 🚀

miguelnietoa merged commit 3be1a67 into v0.19

2 checks passed

miguelnietoa deleted the support-new-field-in-send-transaction-response branch

January 31, 2024 21:35

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet