Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

track go/issues/54136 : per-request timeouts #92

Open
komuw opened this issue Aug 1, 2022 · 4 comments · May be fixed by #213
Open

track go/issues/54136 : per-request timeouts #92

komuw opened this issue Aug 1, 2022 · 4 comments · May be fixed by #213

Comments

@komuw
Copy link
Owner

komuw commented Aug 1, 2022

golang/go#54136
@komuw komuw changed the title track go/issues/54136 track go/issues/54136 : per-request timeouts Sep 7, 2022
@komuw
Copy link
Owner Author

komuw commented Sep 28, 2022

Note that the current TimeoutHandler that we use does not support Hijacker or Flusher interface; golang/go@46e0d72

@komuw
Copy link
Owner Author

komuw commented Jan 16, 2023

Note that this will be in Go1.20: golang/go@fd0c0db

From that commit message, we can now do;

        c := http.NewResponseController(w)
	c.Flush()

vs.

	if f, ok := w.(http.Flusher); ok {
		f.Flush()
	}

@komuw
Copy link
Owner Author

komuw commented Feb 2, 2023 •
edited
Loading

golang/go#58237 : panic in Go

@komuw komuw linked a pull request Feb 3, 2023 that will close this issue
Draft
@komuw
Copy link
Owner Author

komuw commented Mar 9, 2023

https://www.alexedwards.net/blog/how-to-use-the-http-responsecontroller-type

@komuw komuw mentioned this issue Aug 28, 2023
Merged
komuw added a commit that referenced this issue Aug 28, 2023
@komuw
issues/92: Add support for http.NewResponseController (#368)
622b997 
- Updates: #92
- This still doesn't fix the issue, there is still #213 for that
@komuw komuw mentioned this issue Feb 9, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

issues/92: http.NewResponseController komuw/ong
1 participant
@komuw