Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make PR in related repos bumping versions when a deploy is performed #2

Open
soywiz opened this issue May 6, 2020 · 12 comments
Open
Assignees
Labels
enhancement New feature or request

Comments

@soywiz
Copy link
Contributor

soywiz commented May 6, 2020

For example if we release a new version of Klock, the bot should make a PR to korio bumping version in its gradle.properties so people in the team can merge it

@soywiz soywiz added the enhancement New feature or request label May 6, 2020
@soywiz soywiz self-assigned this May 6, 2020
@emign
Copy link

emign commented Jun 24, 2020

did you already start this?

@emign emign closed this as completed Jun 24, 2020
@emign emign reopened this Jun 24, 2020
@soywiz
Copy link
Contributor Author

soywiz commented Jun 24, 2020

Not started yet

@emign
Copy link

emign commented Jun 24, 2020

do you want it to be in GitHub actions?

@soywiz
Copy link
Contributor Author

soywiz commented Jun 24, 2020

yeah, I think that would be the best place

@emign
Copy link

emign commented Jun 25, 2020

To prevent an intransparent web of bots updating all libs on their own I suggest a korlibs version repository which just holds all the version numbers. The subrepos then get an action when they have a new deploy to update the central version number repository.
When someone merges the PR in the versioning repository it can fan out to creating PRs on the subrepos.

Bildschirmfoto 2020-06-25 um 09 13 42

Any complains or suggestions?

@soywiz
Copy link
Contributor Author

soywiz commented Jun 25, 2020

Cool. Great idea

@emign emign self-assigned this Jun 25, 2020
@emign
Copy link

emign commented Jun 26, 2020

Please check for missing modules/repos https://github.com/korlibs/korlibs-versions

@emign
Copy link

emign commented Jun 26, 2020

Please check. https://github.com/korlibs/klock/blob/versioningWorkflow/.github/workflows/VERSIONSYNCTEST.yml
Failing atm due to missing authorization rights. Could issue a personal access token, but that would be bound to my account. Need another way or create a bot account on GitHub with according privileges to make PRs

@emign
Copy link

emign commented Jul 9, 2020

Okay. Finally. We needed to add korgebot to write access members for korlibs-versions. Didn't think about that. We dont fork but rather create PRs on korlibs-versions

This workflow now adds PRs whenever klock changes. We would need to adapt this for every sub library and add it to the deploy workflow (since GHA workflows cannot trigger other workflows on their own as I recall). We should review this workflow before we proliferate it though.

Then we should leave it running for some days/deploys to see if any weird things happen on korlibs-versions. After that we could think about using it as a version-number-server

@soywiz
Copy link
Contributor Author

soywiz commented Jul 9, 2020

I think that bot should directly write to the korlibs-versions repo then that repo fanout to the right repos with PRs. If we make a PR to korlibs-versions that would delay the other PRs

@emign
Copy link

emign commented Jul 9, 2020

We could auto merge the PRs. Will that work?

EDIT: There wouldn't be much of a difference if the PRs are auto merged vs direct writing. Ill change the bot to directly commit

@emign
Copy link

emign commented Jul 9, 2020

The bot now commits directly to the master of korlibs-versions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants