-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make PR in related repos bumping versions when a deploy is performed #2
Comments
did you already start this? |
Not started yet |
do you want it to be in GitHub actions? |
yeah, I think that would be the best place |
To prevent an intransparent web of bots updating all libs on their own I suggest a korlibs version repository which just holds all the version numbers. The subrepos then get an action when they have a new deploy to update the central version number repository. Any complains or suggestions? |
Cool. Great idea |
Please check for missing modules/repos https://github.com/korlibs/korlibs-versions |
Please check. https://github.com/korlibs/klock/blob/versioningWorkflow/.github/workflows/VERSIONSYNCTEST.yml |
Okay. Finally. We needed to add korgebot to write access members for korlibs-versions. Didn't think about that. We dont fork but rather create PRs on korlibs-versions This workflow now adds PRs whenever klock changes. We would need to adapt this for every sub library and add it to the deploy workflow (since GHA workflows cannot trigger other workflows on their own as I recall). We should review this workflow before we proliferate it though. Then we should leave it running for some days/deploys to see if any weird things happen on korlibs-versions. After that we could think about using it as a version-number-server |
I think that bot should directly write to the korlibs-versions repo then that repo fanout to the right repos with PRs. If we make a PR to korlibs-versions that would delay the other PRs |
We could auto merge the PRs. Will that work? EDIT: There wouldn't be much of a difference if the PRs are auto merged vs direct writing. Ill change the bot to directly commit |
The bot now commits directly to the master of korlibs-versions |
For example if we release a new version of Klock, the bot should make a PR to korio bumping version in its
gradle.properties
so people in the team can merge itThe text was updated successfully, but these errors were encountered: