-
-
Notifications
You must be signed in to change notification settings - Fork 156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
A couple strange behaviors on input #456
Comments
Yes, thanks, I will have a look. |
This turned out to have somewhat complicated implications. There are quite large changes in the latest beta release, hopefully this should fix some bug as well as improve performance in some cases. The first bug should be fixed. About the second bug, for clarification : validateOn doest not control when the ajv validation is performed, but rather when the fields are considered as validated by the user (and so when errors should be displayed in the UI). Still there was a bug indeed. At least one case is fixed, I you still encounter an invalid behavior feel free to reopen the issue. |
Thank you very much for a fast response (as usual!) The first bug indeed seems to be completely resolved, but sadly I'm experiencing some very strange behavior in beta.46, although this is perhaps due to my implementation. I'm using a property directly from my pinia store as vjsf's v-model with toRefs(store) (this is perhaps unadvisable?), which seems to have worked mroe or less properly before, however, in the latest version, when I manually edit any value in the form for the first time (after it gets initially hydrated with data from the store), the entire form is emptied except for the value I edited. The consequent edits, however, work just as expected. Additionally, whenever I update the value in the store by any other mean, the form updates as well, and displays the correct data... however if I once again modify any value in the form manually, it goes back to the previous state, as if there were two forms - one that's correctly displaying the data from the store and the other that is completely independent from it. Would you happen to have any idea what could be causing this? Could this indeed be related to my using a state value as v-model, or does that have nothing to do with it? Also, please let me know if you would prefer that I create a separate issue for this. |
No need to open a new issue. Are you sure the vjsf version is the only change in the code base ? For now I fail to see what could cause what you observe. Using the editor shows that data-binding works in both directions (input from the form and applying external mutations). I don't know why using some state value from pinia would change that if it is exposed as a normal ref by toRefs. If you don't find the bug yourself you can post some reproduction. I don't know what the best way to do it would be, maybe you could work in this directory in a fork. |
Yeah, I've re-checked and it is indeed just the vjsf version; specifically the issue arises when going from beta-45 to beta-46. |
Hi, I have noticed a couple of issues when inputting values into the form that seem to not have been present before (although I don't know exactly when they appeared as I've only recently migrated to the vue3 version):
These are obviously not massive problems, but they seem somewhat obscure so I wanted to bring them to your attention.
The text was updated successfully, but these errors were encountered: