Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "alter" combinator #95

Merged
merged 7 commits into from
Oct 25, 2020
Merged

Add "alter" combinator #95

merged 7 commits into from
Oct 25, 2020

Conversation

ChrisPenner
Copy link
Collaborator

This would've come in really handy on a recent project I was working on 😄

Inspired by alter from Data.Map

@chshersh chshersh added Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest labels Oct 6, 2020
@ChrisPenner
Copy link
Collaborator Author

Rebased and ready 👍

chshersh
chshersh approved these changes Oct 16, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪
Really enjoy reviewing your code 🤗

src/Data/TypeRepMap/Internal.hs Outdated Show resolved Hide resolved
test/Test/TypeRep/TypeRepMapProperty.hs Show resolved Hide resolved
@chshersh chshersh added this to the v0.4.0.0: Boost milestone Oct 17, 2020
@ChrisPenner
Copy link
Collaborator Author

Old GHC versions are fixed up 👍

If you're happy with the addition of !===! I'll rebase the intersection PR on top of it once this is merged and use the same fix there 😄

@ChrisPenner
Copy link
Collaborator Author

ChrisPenner commented Oct 24, 2020 •
edited
Loading

Any news on this one? @vrom911 @chshersh

Whoops, didn't see your comment on the orphan instance; went ahead and added that 👍

chshersh
chshersh approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@chshersh chshersh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ChrisPenner Great job! 👏

@chshersh chshersh merged commit 1b739d8 into kowainik:master Oct 25, 2020
@ChrisPenner
Copy link
Collaborator Author

@vrom911 @chshersh

Would we be able to ship a new version with this combinator included sometime? Was just working on a new project where it'd be handy to have, and it doesn't seem to be up on hackage yet. 😄

@chshersh
Copy link
Contributor

chshersh commented Aug 3, 2021

@ChrisPenner We finally published typerep-map-0.4.0.0 to Hackage including all these changes 💎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chshersh chshersh chshersh approved these changes

@vrom911 vrom911 Awaiting requested review from vrom911

Assignees

@ChrisPenner ChrisPenner

Labels
Hacktoberfest https://hacktoberfest.digitalocean.com/ hacktoberfest-accepted Accept contributions during Hacktoberfest
Projects
None yet
Milestone
v0.4.0.0: Boost
Development

Successfully merging this pull request may close these issues.
2 participants
@ChrisPenner @chshersh