Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor (Fingerpring, Any, Any) to a data type #98

Open
chshersh opened this issue Oct 12, 2020 · 1 comment
Open

Refactor (Fingerpring, Any, Any) to a data type #98

chshersh opened this issue Oct 12, 2020 · 1 comment
Assignees

Comments

@chshersh
Copy link
Contributor

It would be better to have a special data type for this. And also special functions to convert to this datatype. This should improve code readability. And, possible, performance, if we add {-# UNPACK #-} pragmas where possible

@ChrisPenner
Copy link
Collaborator

ChrisPenner commented Oct 17, 2020

A custom unpacked datatype is the way to go here, but failing that, there's also -XUnboxedTuples

Be wary about anything that might make the Any strict though; as that would change end-user behaviour (unless something is already forcing the values to the map that I haven't seen, not sure how Any is affected by Array.)

@chshersh chshersh removed this from the v0.4.0.0: Boost milestone Aug 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants