Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Cleanup prometheus metrics after Rebalancing #15

Closed
marcosschroh opened this issue Jul 21, 2022 · 1 comment
Closed

Cleanup prometheus metrics after Rebalancing #15

marcosschroh opened this issue Jul 21, 2022 · 1 comment
Assignees
@marcosschroh

Comments

@marcosschroh
Copy link
Collaborator

Describe the bug
After a Rebalancing the StreamEngine could contain metrics of partitions that where assigned to other StreamEngine instances which are running in different node. We need to make sure that we clean the old metrics.

To Reproduce
Start with x amount of instances, scale up/down and the StreamEngine contains old metrics.

Solution

Use the ConsumerRebalanceListener to listen for Rebalancing events. We have an open PR on aiokafka to be able to create a consumer with a ConsumerRebalanceListener.
@marcosschroh marcosschroh self-assigned this Jul 26, 2022
@marcosschroh
Copy link
Collaborator Author

Closed by #104

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@marcosschroh marcosschroh

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@marcosschroh