Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fixtures (example files) for each transaction set #181

Open
39 tasks
kputnam opened this issue Feb 19, 2019 · 1 comment
Open
39 tasks

Add fixtures (example files) for each transaction set #181

kputnam opened this issue Feb 19, 2019 · 1 comment

Comments

@kputnam
Copy link
Owner

kputnam commented Feb 19, 2019

These transaction sets don't yet have any fixtures, so there aren't any automated tests to ensure their definitions can parse actual files. Even though these might be correct and working fine now, adding fixtures will help prevent any inadvertent regressions when changes are made to other parts of the library.

It is fairly straightforward to add fixtures, just look in spec/fixtures for examples. Then you can run rspec -Ilib -Ispec -rspec_helper --tag fixtures spec to test them (or you can run rake spec to run all specs).

If you have files but want to remove any sensitive information, you can use bin/edi-obfuscate to replace all strings, dates, times, and numbers with placeholder values, before adding to the repository.

  • 002001/FA997
  • 002001/PO830
  • 002001/SH856
  • 003010/PC860
  • 003010/PO850
  • 003010/PS830
  • 003010/RA820
  • 003040/WA142
  • 003050/PO850
  • 004010/AR943
  • 004010/FA997
  • 004010/GF990
  • 004010/HP835
  • 004010/IM210
  • 004010/OW940
  • 004010/PO850
  • 004010/PR855
  • 004010/PS830
  • 004010/QM214
  • 004010/RE944
  • 004010/SC832
  • 004010/SH856
  • 004010/SM204
  • 004010/SQ866
  • 004010/SS862
  • 004010/SW945
  • 004010/X091A1 HP835
  • 005010/X214 HN277
  • 005010/X220 BE834
  • 005010/X221 HP835
  • 005010/X222 HC837
  • 005010/X222 HC837
  • 005010/X222A1 HC837
  • 005010/X223 HC837
  • 005010/X223 HC837
  • 005010/X223A1 HC837
  • 005010/X223A3 HC837
  • 005010/X231 FA999
  • 005010/X279 HS270
@kputnam
Copy link
Owner Author

kputnam commented Feb 19, 2019

Note some of the 005010 implementations (eg, X221, X222) are deprecated and newer versions (eg X221A1) do have fixtures. It would still be useful to add these fixtures to ensure the new grammar is backward compatible and can parse older versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant