Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update for enjoi and tape packages, change dev dependencies. #97

Open
wants to merge 14 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions .eslintignore
Original file line number Diff line number Diff line change
@@ -0,0 +1,4 @@
.git
coverage
node_modules
test
15 changes: 15 additions & 0 deletions .eslintrc.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,15 @@
{
"env": {
"browser": false,
"commonjs": true,
"es2021": true
},
"extends": [
"airbnb-base"
],
"parserOptions": {
"ecmaVersion": 12
},
"rules": {
}
}
2 changes: 2 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -34,3 +34,5 @@ Thumbs.db
.LSOverride
.Spotlight-V100
.Trashes
.vscode/
.nyc_output
69 changes: 0 additions & 69 deletions .jshintrc

This file was deleted.

5 changes: 1 addition & 4 deletions .travis.yml
Original file line number Diff line number Diff line change
@@ -1,9 +1,6 @@
language: node_js
node_js:
- "0.12"
- "4"
- "6"
- "8"
- "12"

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should add 14

branches:
only:
- master
Expand Down
6 changes: 6 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,3 +1,9 @@
### 1.0.12

- Update to node v10, add `package-lock.json` file

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should this be v12?

Might also want to make a bigger version jump if we are ruling out old node versions

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 on Node 12. Maybe it can be changed to node 10+.
Curious, is package-lock.json for unit tests? Shouldn't unit tests always run on the latest dependency versions?

- Update for following dependencies: `enjoi` and `tape`
- Use of `eslint` instead of `jshint` as linter tool. Use of `nyc` instead of `istambul` as a code coverage tool.

### 1.0.11

- Fix #76 - parameter minLength is overridden with value 0
Expand Down
Loading