[BUG] Add Lead Buttons Do Nothing

[ghost]

Bug report

Kanban Add Leads Button Has No Effect

Issue Description

In the Leads package, each Kanban board has an href button that says Add Lead. Clicking them has no effect.

Preconditions

PHP 8.0.7 on Laravel Valet
Krayin v1.1.2

Steps to reproduce

Go to Leads page, see kanban board stages, click on outline button with text Add Lead.

Expected result

Clicking on the Add Lead button should ideally produce a modal to add the lead to the specific stage, or at minimum redirect to the leads/create page.

Actual result

Nothing happens, no modal opens or redirect occurs, just an empty pointless click.

[Sanjaybhattwebkul]

@19peaches
This issue is fixed in master. : #244
Please take a pull from master. then try again.
If you will get the same issue then let me know

[ghost]

Hey Sanjay, thanks for that.

I installed with composer as per your docs, since none of this is registered as a vendor package, except the krayin/krayin-package-generator package, I have no way to pull master into my root directory.

Should I just nuke this and re-install via cloning the repo?

[Sanjaybhattwebkul]

Yes, you should re-install via cloning the repo

[ghost]

Ok thanks.

[ghost]

How do I get all the javascript assets installed and compiled, do I have to go into each of the packages and run these individually or something?

[devansh-webkul]

Hi @19peaches,

Are you working on the package?

[ghost]

Well I'd like to, once I wrap my head around your set up.

I certainly have some cool integrations to add that we use in our business.

For now, I need to get it running.

[devansh-webkul]

Well if you are working in the package then you need to compile the package individually but make sure you are aware of the updates because it's the same thing as the vendor folder.

As I recommend you to publish all the packages and override the methods which you think it's not suitable for your business.

[ghost]

I'm trying to do an initial install.

I cloned the repo per Sanjay's instruction.

Ran composer install, created an app key, ran krayin:install ran npm install and npm run dev

I have no node_modules folder and no assets compiled.

[devansh-webkul]

After krayin install no need for any assets compiled because we already delivered compiled assets and it's already published during installation.

If you run npm install and npm run dev that is your project environment which is in the root.

[ghost]

Well after krayin:install I get this:

[ghost]

And before you ask, there were no errors from the installer when I ran it.

[devansh-webkul]

Just run php artisan vendor:publish --all --force.

[ghost]

Ok that worked.

Now when I want to make some changes to js or scss in a given package, what are the steps to follow to republish?

[devansh-webkul]

• Go to a specific package.
• Run npm install.
• Run npm run dev or npm run watch as per your requirement. Once you are done with your development.
• Run npm run prod.
• Run php artisan vendor:publish --all --force or specific package you want.

[ghost]

Great thanks.

I just noticed that now, the lead stages are all chopped off from the way they were.

[devansh-webkul]

This has been fixed recently. Just run git pull, if you have taken clone.

[ghost]

Will do.

One last question, how can I build on the core packages when any pull will overwrite my changes?

[devansh-webkul]

Well if you are working in the package then you need to compile the package individually but make sure you are aware of the updates because it's the same thing as the vendor folder.

As I recommend you to publish all the packages and override the methods which you think it's not suitable for your business.

Well, I already told you here.

[ghost]

The issue with the stage being cut off is not fixed.

I have the latest code and it remains the same.

[devansh-webkul]

Just wait for merging of this, take a pull,
#271

And then run,
php artisan vendor:publish --all --force

[ghost]

Got it. Thanks.