Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TSLint file level rules removed #25

Closed
cgatian opened this issue Aug 24, 2020 · 1 comment · Fixed by #36
Closed

TSLint file level rules removed #25

cgatian opened this issue Aug 24, 2020 · 1 comment · Fixed by #36
Assignees
@shaharkazaz
Labels
bug Something isn't working released

Comments

@cgatian
Copy link

cgatian commented Aug 24, 2020 •
edited
Loading

If a TSLint rule exists as the first line of a file (to disable a rule scoped to the file) these rules are removed

Original:

 // tslint:disable: jsdoc-format
import { func } from 'myLib';

Output:

import { func } from 'myLib';

I should also mention something odd is happening with Angular CLI's polyfills.ts. This file has a bunch of jsdoc comments that get malformed when import-conductor is ran against it.
@shaharkazaz shaharkazaz mentioned this issue Aug 31, 2020
Closed
@shaharkazaz shaharkazaz added bug Something isn't working PRs welcome labels Aug 31, 2020
shaharkazaz added a commit that referenced this issue Sep 1, 2020
@shaharkazaz
fix: 🐛 conductor removing comments from the imports section
05f0215 
✅ Closes: #25
@shaharkazaz shaharkazaz linked a pull request Sep 1, 2020 that will close this issue
fix/import-section-comments-removed #36
Merged
@shaharkazaz shaharkazaz self-assigned this Sep 1, 2020
nivekcode pushed a commit that referenced this issue Sep 1, 2020
@semantic-release-bot
chore(release): 2.0.2 [skip ci]
6a41aba 
## [2.0.2](v2.0.1...v2.0.2) (2020-09-01)

### Bug Fixes

* 🐛 conductor removing comments from the imports section ([05f0215](05f0215)), closes [#25](#25)
@nivekcode
Copy link
Owner

🎉 This issue has been resolved in version 2.0.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@shaharkazaz shaharkazaz

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix/import-section-comments-removed nivekcode/import-conductor
3 participants
@cgatian @nivekcode @shaharkazaz