-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Verbose doesn't work with this library, it never did #113
Comments
PR is merged, will be available in version 5.0.0 of |
Closing as v5 of |
It's not tagged yet, latest release still is |
ok, reopening |
v5.0.0 of |
You really should explicitly say in README.md that node-sqlite supports v5. |
Not sure why this is important? Unless there's a v6 and there's some incompat issue that can't be addressed. So far the recent versions of |
I was never able to make
verbose
work with this library, consider the following example :It's a very basic example, but the error throws doesn't have any trace info :
I first thought it was a bug, I forked the repo and tried to solve it, but it turned out it's not possible from this library because
node-sqlite3
adds the trace info by catching an error you should throw, and throwing it instead ofreject()
causes the promise to never reject because an error thrown in an async callback cannot be caught by the promise.I then sent an issue and a PR to fix it in
node-sqlite3
repo.I opened this issue here for anyone trying to figure out why it's not working with
node-sqlite
, please keep it open until the problem is fixed in the other repo, if it's not accepted there then update the docs so no one loses his mind trying to figure out the problem.The text was updated successfully, but these errors were encountered: