Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add libvips support #53

Open
romanzks opened this issue Nov 8, 2022 · 2 comments
Open

Add libvips support #53

romanzks opened this issue Nov 8, 2022 · 2 comments

Comments

@romanzks
Copy link

romanzks commented Nov 8, 2022

Feature: Add libvips support for image processing.
https://github.com/libvips/libvips
https://github.com/libvips/php-vips

It would be convenient, because now I have to use GD or Imagick to work with Color Thief PHP, while the rest of the processing is done by the libvips.

@ksubileau
Copy link
Owner

ksubileau commented Nov 9, 2022

Thank you for your suggestion.

Libvips looks great, but I feel like it's not very commonly used, so I'm not sure it's worth adding official support for it right now. I'll probably wait to see if other people ask for this feature.

In the meantime, since the 2.0.0 release, it should still be possible to implement this support on your side, by providing an instance of a class implementing the ColorThief\Image\Adapter\AdapterInterface interface to the $adapter parameter of ColorThief::getColor and ColorThief::getPalette methods. Let me know if it works and can meet your need.

@romanzks
Copy link
Author

romanzks commented Nov 9, 2022

Thanks for considering my suggestion and for the tip on the implementation of the functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants