Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

White line between promoted properties with attributes #787

Open
tjveldhuizen opened this issue May 20, 2022 · 2 comments
Open

White line between promoted properties with attributes #787

tjveldhuizen opened this issue May 20, 2022 · 2 comments
Labels

Comments

@tjveldhuizen
Copy link

Would it be possible to adapt MultilinePromotedPropertiesFixer in such way that white lines are added between promoted properties with PHP attributes? I think the first code block is much more readable than the second.

    public function __construct(
        #[ORM\Column]
        #[Assert\NotBlank]
        private string $name,

        #[ORM\Column]
        #[Assert\NotBlank]
        private string $organisation,

        #[ORM\Column(type: 'boolean')]
        private bool $idRequired,

        private bool $profilePossible,
        private bool $isInternal
    ) {
    }
    public function __construct(
        #[ORM\Column]
        #[Assert\NotBlank]
        private string $name,
        #[ORM\Column]
        #[Assert\NotBlank]
        private string $organisation,
        #[ORM\Column(type: 'boolean')]
        private bool $idRequired,
        private bool $profilePossible,
        private bool $isInternal
    ) {
    }
@kalinowski5
Copy link

Seems to be related: squizlabs/PHP_CodeSniffer#3323

@kubawerlos
Copy link
Owner

Wouldn't method_argument_space be a better place to handle it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants