Skip to content
This repository has been archived by the owner on Sep 12, 2023. It is now read-only.

Use Interface instead of lister/informer in controller #157

Open
Jeffwan opened this issue Aug 30, 2021 · 3 comments
Open

Use Interface instead of lister/informer in controller #157

Jeffwan opened this issue Aug 30, 2021 · 3 comments

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Aug 30, 2021

A follow up PR of #155

In the common code base, we still use low level listers and hasSynced which is not used in training-operator any more.
Let's change to XXInterface from kubeClientSet. Otherwise, we have to create sharedInformers and then create listers which is unnecessary in latest client pattern
@zw0610
Copy link
Member

zw0610 commented Aug 30, 2021

Good idea. May I assign this feature to myself?

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021 •
edited
Loading

/assign @zw0610

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 30, 2021

@zw0610 sure. Feel free to pick it up

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Jeffwan @zw0610