Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Skip non-root user processes when waiting for main proces to end #1383

Closed
robbertvdg opened this issue Nov 9, 2020 · 0 comments
Closed

Skip non-root user processes when waiting for main proces to end #1383

robbertvdg opened this issue Nov 9, 2020 · 0 comments
Labels

Comments

@robbertvdg
Copy link
Contributor

/kind bug

What steps did you take and what happened:
Metrics cannot be collected while running trials with Istio enabled. The metrics pod keeps running without sending metrics to the db-manager. After debugging I found out that the function GetMainProcesses() waits forever for the Istio sidecar (envoy proxy) to finish. The istio sidecar does not run as root and should therefore be skipped in this proces. The parent process of istio however is the root user (which determines if a process is ran as root). We can check for user id instead of pid parent.

What did you expect to happen:
The istio sidecar should not be considered while checking for the main process to be finished.

Anything else you would like to add:
I will make a PR with a fix.

Environment:

  • Kubeflow version 1.0
  • Minikube version (minikube version):
  • Kubernetes version: (use kubectl version): 1.18.10
  • OS (e.g. from /etc/os-release):
@robbertvdg robbertvdg changed the title Non-root process not identified correctly while waiting for process to end Skip non-root user processes when waiting for main proces to end Nov 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants