Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename request_number parameter in gRPC manager #1637

Closed
andreyvelich opened this issue Aug 24, 2021 · 3 comments · Fixed by #1728
Closed

Rename request_number parameter in gRPC manager #1637

andreyvelich opened this issue Aug 24, 2021 · 3 comments · Fixed by #1728
Assignees
@johnugeorge @andreyvelich
Labels
kind/feature

Comments

@andreyvelich
Copy link
Member

/kind feature

This PR: #1633 introduces total_request_number parameter.
To be consistent, we should rename request_number to current_request_number.
After that, all suggestions have to be modified.

Does it sound good to you @johnugeorge @gaocegege ?
@johnugeorge
Copy link
Member

LGTM

/assign

@gaocegege
Copy link
Member

SGTM

@andreyvelich
Copy link
Member Author

/assign @andreyvelich

@andreyvelich andreyvelich mentioned this issue Nov 2, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@johnugeorge johnugeorge

@andreyvelich andreyvelich

Labels
kind/feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Modify gRPC API with Current Request Number andreyvelich/katib
4 participants
@johnugeorge @gaocegege @andreyvelich @google-oss-robot