Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Kubernetes Sidecars for Katib Metrics Collectors #2181

Open
andreyvelich opened this issue Jul 28, 2023 · 4 comments
Open

Support Kubernetes Sidecars for Katib Metrics Collectors #2181

andreyvelich opened this issue Jul 28, 2023 · 4 comments

Comments

@andreyvelich
Copy link
Member

Recently Kubernetes added native support for sidecars containers as part of KEP 753: kubernetes/enhancements#3761

We need to discuss if we can improve our architecture to run Katib Metrics Collectors as Kubernetes sidecars.
It requires to use initContainer with restartPolicy: Always to run the container as a sidecar.

This feature will be available only in Kubernetes 1.28, but we can start the design discussions now.

Existing problems with Katib Metrics Collectors Sidecar:

cc @kubeflow/wg-automl-leads @tenzen-y @gaocegege @votti

@tenzen-y
Copy link
Member

@andreyvelich Thank you for raising this proposal!
I agree with you because by supporting the sidecars pattern, we can avoid manually managing the termination of the metrics collector.

https://github.com/kubeflow/katib/blob/master/pkg/metricscollector/v1beta1/common/pns.go.

Also, we might be able to support Istio.

@github-actions
Copy link

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@tenzen-y
Copy link
Member

/lifecycle freeze

@tenzen-y
Copy link
Member

/lifecycle frozen

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants