Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move ksonnet, kustomize implementations out of KfApps.Children #2561

Closed
kkasravi opened this issue Feb 26, 2019 · 4 comments
Closed

Move ksonnet, kustomize implementations out of KfApps.Children #2561

kkasravi opened this issue Feb 26, 2019 · 4 comments

Comments

@kkasravi
Copy link
Contributor

The kfctl Client is defined as

type KfApps struct {
	Children map[string]KfApp
}
type kfApp struct {
	kftypes.KfApps
	Client *cltypes.Client
}

where currently Ksonnet, Gcp, Minikube and other types implementing KfApp are added to
the Children member. Ksonnet is added as "none" based on legacy code in kfctl.sh.
We should redefine this to be:

type KfApps struct {
	Platforms map[string]KfApp
         PackageManagers map[string]KfApp
}
type kfApp struct {
	kftypes.KfApps
	Client *cltypes.Client
}

This would then be used to cleanly separate platforms from package managers.

@kkasravi
Copy link
Contributor Author

/area kfctl

@kkasravi
Copy link
Contributor Author

/priority p1

@kkasravi
Copy link
Contributor Author

/assign @kkasravi

@kkasravi
Copy link
Contributor Author

fixed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants