Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Question] PhantomJS #3110

Closed
sakaia opened this issue Feb 19, 2020 · 4 comments · Fixed by #3113
Closed

[Question] PhantomJS #3110

sakaia opened this issue Feb 19, 2020 · 4 comments · Fixed by #3113

Comments

@sakaia
Copy link

sakaia commented Feb 19, 2020

The frontend uses PhantomJS.
Regrettably, the PhantomJS will stop development.
Of course, kubernetes/pipelines used the PhantomJS in build time only.

Is there any plan to move from PhantomJS?
If so, which package you will plan to use?

Reference

@rmgogogo
Copy link
Contributor

@Bobgy

@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

Thanks @sakaia for raising the question.

I took this opportunity to investigate a little. Here's what I found:

Backstop js itself has removed phantomjs support in a later release: garris/BackstopJS#772 (comment)

We have a few options:

  1. Upgrad backstop js and restore backstop js tests
  2. Just delete them

So far, I don't feel we have a strong need for visual regression testing, so I will go with deletion to simplify maintenance.

@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

And FYI, for UI integration testing, we are using selenium (I'm thinking about replacing it with cypress, puppeteer or https://github.com/microsoft/playwright later, but not now).

@Bobgy
Copy link
Contributor

Bobgy commented Feb 19, 2020

Sent above PR to remove backstop js, and thus also dependency of phantom js.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants