Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TFJob Operator: Move manifests development upstream #1246

Closed
yanniszark opened this issue Feb 10, 2021 · 0 comments · Fixed by #1247
Closed

TFJob Operator: Move manifests development upstream #1246

yanniszark opened this issue Feb 10, 2021 · 0 comments · Fixed by #1247
Assignees

Comments

@yanniszark
Copy link
Contributor

Background

Umbrella-Issue: kubeflow/manifests#1740

As part of the work of wg-manifests for 1.3
(kubeflow/manifests#1735), we are moving manifests
development to upstream repos. This gives the application developers full
ownership of their manifests, tracked in a single place.

To give an example from the notebook-controller, the diagram shows the current
situation. Manifests are in two repos, blurring separation of responsibilities
and making things harder for application developers.

diagram_1

Instead, we will copy all manifests from the manifests repo back to each
upstream's repo. From there, they will be imported in the manifests repo. The
following diagram presents the desired state:

diagram_2

Current State

TFJob Operator has manifests:

Desired State

The proposed folder in the upstream repo to receive the manifests is:
deploy/v1.

The goal is to consolidate all manifests development in the upstream repo.
The manifests repo will include a copy of the manifests under apps/tf-training/upstream.
This copy will be synced periodically.

Success Criteria

The manifests in apps/tf-training/upstream should be a copy of the upstream manifests
folder. To do that, the application manifests in kubeflow/manifests should be
moved to the upstream application repo.

/assign @yanniszark
cc @kubeflow/wg-training-leads

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant