Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Universal Operator Phase II: Reduce duplication and extract common utilities #1299

Closed
Jeffwan opened this issue Jul 11, 2021 · 4 comments
Closed
Assignees

Comments

@Jeffwan
Copy link
Member

Jeffwan commented Jul 11, 2021

In Phase I #1298, we try to replicate codes from different operator directly and make them work without further optimization. This is part of kubeflow/common#138

However, this is not the ultimate goal. We can see there're lots of duplications and inefficient usage. in Phase II, we want to

  1. Eliminate difference between operators and make them have same coding structure (including apis, docs, openapi specs)
  2. Extract common methods to utilities which can be shared by all operators.
  3. Simplify controller code structures. Merge pods.go service.go job.go into one file which is the core JobController implementation.
  4. Make all operator pass tests and manually run tests against new operator
@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 29, 2021

The last part of this PR is

  1. Fix all the issues to run multiple controllers correctly. Controller can not successfully run due to conflicts index fields #1312
  2. Run more testing to make sure current behavior is same as original operator

@Jeffwan
Copy link
Member Author

Jeffwan commented Jul 31, 2021

We need to fix these critical bugs to make sure old tensorflow controller work as well.

#1312
#1314
#1316
#1317

This make us comfortable to merge this branch to master and also make both old & new operator works together in one code base

@Jeffwan
Copy link
Member Author

Jeffwan commented Aug 2, 2021

We can close this issue now.

/close

@google-oss-robot
Copy link

@Jeffwan: Closing this issue.

In response to this:

We can close this issue now.

/close

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants