Skip to content

Commit

Permalink
fix as lint
Browse files Browse the repository at this point in the history
Signed-off-by: bobz965 <[email protected]>
  • Loading branch information
bobz965 committed Aug 12, 2024
1 parent cf15d64 commit b81141a
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 6 deletions.
2 changes: 1 addition & 1 deletion pkg/util/validator.go
Original file line number Diff line number Diff line change
Expand Up @@ -83,7 +83,7 @@ func ValidateSubnet(subnet kubeovnv1.Subnet) error {
return err
}
if _, _, err := net.ParseCIDR(cidr); err != nil {
return fmt.Errorf("subnet %s allowSubnets cidr %s is not a valid address", subnet.Name, cidr)
return fmt.Errorf("%s in allowSubnets is not a valid address", cidr)
}
}

Expand Down
1 change: 0 additions & 1 deletion pkg/webhook/vip.go
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,6 @@ import (

metav1 "k8s.io/apimachinery/pkg/apis/meta/v1"
"k8s.io/apimachinery/pkg/types"
"k8s.io/klog/v2"
ctrlwebhook "sigs.k8s.io/controller-runtime/pkg/webhook"
"sigs.k8s.io/controller-runtime/pkg/webhook/admission"

Expand Down
8 changes: 4 additions & 4 deletions test/e2e/vip/e2e_test.go
Original file line number Diff line number Diff line change
Expand Up @@ -140,11 +140,11 @@ var _ = framework.Describe("[group:vip]", func() {
cidr = framework.RandomCIDR(f.ClusterIPFamily)

// should create lower case static ipv6 address vip in ovn-defualt

Check failure on line 142 in test/e2e/vip/e2e_test.go

View workflow job for this annotation

GitHub Actions / Build kube-ovn

`defualt` is a misspelling of `default` (misspell)
lowerCaseStaticIpv6VipName := "lower-case-static-ipv6-vip-" + framework.RandomSuffix()
lowerCaseV6IP := "fd00:10:16::a1"
lowerCaseStaticIpv6VipName = "lower-case-static-ipv6-vip-" + framework.RandomSuffix()
lowerCaseV6IP = "fd00:10:16::a1"
// should not create upper case static ipv6 address vip in ovn-defualt

Check failure on line 145 in test/e2e/vip/e2e_test.go

View workflow job for this annotation

GitHub Actions / Build kube-ovn

`defualt` is a misspelling of `default` (misspell)
upperCaseStaticIpv6VipName := "Upper-Case-Static-Ipv6-Vip-" + framework.RandomSuffix()
upperCaseV6IP := "fd00:10:16::A1"
upperCaseStaticIpv6VipName = "Upper-Case-Static-Ipv6-Vip-" + framework.RandomSuffix()
upperCaseV6IP = "fd00:10:16::A1"

// should have the same mac, which mac is the same as its vpc overlay subnet gw mac
randomSuffix := framework.RandomSuffix()
Expand Down

0 comments on commit b81141a

Please sign in to comment.