fix:react leader elect #2167
Merged
fix:react leader elect #2167
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lut777
force-pushed
the
master
branch
2 times, most recently
from
d8fe016
to
7da6d48
Compare
oilbeater
requested changes
Dec 19, 2022
cmd/controller/controller.go
Outdated
| @@ -20,6 +25,8 @@ import ( | |||
| "github.com/kubeovn/kube-ovn/versions" | |||
| ) | |||
|
|
|||
| const ovnLeadeResource = "kube-ovn-controller" | |||
There was a problem hiding this comment.
Suggested change
| const ovnLeadeResource = "kube-ovn-controller" | |
| const ovnLeaderResource = "kube-ovn-controller" |
| RenewDeadline: 10 * time.Second, | ||
| RetryPeriod: 2 * time.Second, | ||
| Callbacks: leaderelection.LeaderCallbacks{ | ||
| OnStartedLeading: func(ctx context.Context) { |
There was a problem hiding this comment.
should use ctx to control workers
oilbeater
approved these changes
Dec 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Examples of user facing changes:
Which issue(s) this PR fixes:
Fixes #1947
cluster init:
delete and trigger controller exist:
the log of controller who lost leader:
