remove unused subnet status fields #2178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hongzhen-ma
reviewed
Dec 21, 2022
| @@ -179,8 +179,6 @@ type SubnetStatus struct { | |||
| // +patchStrategy=merge | |||
| Conditions []SubnetCondition `json:"conditions,omitempty" patchStrategy:"merge" patchMergeKey:"type"` | |||
|
|
|||
| AvailableIPs float64 `json:"availableIPs"` | |||
| UsingIPs float64 `json:"usingIPs"` | |||
| V4AvailableIPs float64 `json:"v4availableIPs"` | |||
There was a problem hiding this comment.
1、删除字段的话，是不是还需要code-generator重新生成文件？
2、我没找到具体warning打印的地方
There was a problem hiding this comment.
1、删除字段的话，是不是还需要code-generator重新生成文件？ 2、我没找到具体warning打印的地方
https://github.com/kubernetes/client-go/blob/v0.26.0/rest/warnings.go#L70
hongzhen-ma
approved these changes
Dec 21, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of this PR
Which issue(s) this PR fixes:
Fixes the following warning:
This patch also: