Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check network mask when init subnet #4494

Merged
merged 1 commit into from
Sep 29, 2024

Conversation

Longchuanzheng
Copy link
Contributor

Pull Request

What type of this PR

Examples of user facing changes:

  • Bug fixes

Which issue(s) this PR fixes

Fixes #4493

@dosubot dosubot bot added size:M This PR changes 30-99 lines, ignoring generated files. go Pull requests that update Go code labels Sep 9, 2024
@bobz965 bobz965 mentioned this pull request Sep 12, 2024
1 task
pkg/util/net.go Outdated Show resolved Hide resolved
@bobz965
Copy link
Collaborator

bobz965 commented Sep 21, 2024

@Longchuanzheng 这个文件不要提交
image

pkg/util/net.go Outdated Show resolved Hide resolved
pkg/util/validator.go Outdated Show resolved Hide resolved
pkg/util/validator.go Outdated Show resolved Hide resolved
@dosubot dosubot bot added size:S This PR changes 10-29 lines, ignoring generated files. and removed size:M This PR changes 30-99 lines, ignoring generated files. labels Sep 23, 2024
pkg/util/net.go Outdated Show resolved Hide resolved
@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Sep 27, 2024
@Longchuanzheng Longchuanzheng force-pushed the fixInitRangeList branch 2 times, most recently from b9a03a6 to 813f755 Compare September 29, 2024 06:13
pkg/util/validator.go Show resolved Hide resolved
pkg/util/validator.go Outdated Show resolved Hide resolved
pkg/util/net.go Show resolved Hide resolved
@bobz965 bobz965 merged commit 5193704 into kubeovn:master Sep 29, 2024
6 of 7 checks passed
@Longchuanzheng Longchuanzheng deleted the fixInitRangeList branch September 29, 2024 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code lgtm This PR has been approved by a maintainer need backport size:S This PR changes 10-29 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] Add new subnet will get "invalid memory address or nil pointer dereference" err
4 participants