Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate MachineController/OperatingSystemManager and cloudProvider None are mutually exclusive #3369

Closed
wants to merge 1 commit into from
Closed

Validate MachineController/OperatingSystemManager and cloudProvider None are mutually exclusive #3369

wants to merge 1 commit into from

Conversation

kron4eg
Copy link
Member

@kron4eg kron4eg commented Sep 13, 2024

Which issue(s) this PR fixes:

Fixes #3366

What type of PR is this?
/kind bug

Special notes for your reviewer:

Does this PR introduce a user-facing change? Then add your Release Note here:

Validate MachineController/OperatingSystemManager and cloudProvider None are mutually exclusive

Documentation:

NONE

@kron4eg
Validate MachineController/OperatingSystemManager and cloudProvider N…
2918dda 
…one are mutually exclusive

Signed-off-by: Artiom Diomin <[email protected]>
@kubermatic-bot kubermatic-bot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. docs/none Denotes a PR that doesn't need documentation (changes). dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. labels Sep 13, 2024
@kubermatic-bot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
Once this PR has been reviewed and has the lgtm label, please ask for approval from kron4eg. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@kubermatic-bot kubermatic-bot added the size/M Denotes a PR that changes 30-99 lines, ignoring generated files. label Sep 13, 2024
@kubermatic-bot
Copy link
Contributor

@kron4eg: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-kubeone-e2e-aws-default-install-containerd-external-v1.31.0 2918dda link true /test pull-kubeone-e2e-aws-default-install-containerd-external-v1.31.0

Full PR test history

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

xmudrii
xmudrii requested changes Sep 17, 2024
View reviewed changes
Copy link
Member

@xmudrii xmudrii left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As stated in #3366 (comment), we shouldn't forbid this, but properly handle it

@kron4eg kron4eg closed this Oct 3, 2024
@kron4eg kron4eg deleted the mc-osm-cloudprovider-none-validation branch October 3, 2024 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@xmudrii xmudrii xmudrii requested changes

Assignees

@xmudrii xmudrii

Labels
dco-signoff: yes Denotes that all commits in the pull request have the valid DCO signoff message. docs/none Denotes a PR that doesn't need documentation (changes). kind/bug Categorizes issue or PR as related to a bug. release-note Denotes a PR that will be considered when it comes time to generate release notes. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Validation permits having cloudProvider.none and machineController.deploy=true
3 participants
@kron4eg @kubermatic-bot @xmudrii