Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add links #200

Merged
merged 13 commits into from
Aug 27, 2019
Merged

Add links #200

merged 13 commits into from
Aug 27, 2019

Conversation

bells17
Copy link
Contributor

@bells17 bells17 commented Aug 27, 2019 •
edited by saad-ali
Loading 

NONE

@k8s-ci-robot k8s-ci-robot added the do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. label Aug 27, 2019
@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2019
@bells17
Add link: https://github.com/kubernetes-csi/livenessprobe/blob/master…
5aef647 
…/README.md
@bells17
Add link: https://github.com/kubernetes/kubernetes/blob/master/pkg/ap…
e6a751f 
…is/storage/types.go
@bells17
Add link: https://github.com/kubernetes-csi/external-snapshotter/blob…
00f130e 
…/master/pkg/apis/volumesnapshot/v1alpha1/types.go
@bells17
Add link: https://github.com/kubernetes-csi/external-provisioner
39559d5
@bells17
Add link: https://github.com/kubernetes-csi/external-attacher
46692d5
@bells17
Add link: https://github.com/kubernetes-csi/external-snapshotter
2984a05
@bells17
Add link: https://github.com/kubernetes-csi/node-driver-registrar
ea9a6ff
@bells17
Add link: https://github.com/kubernetes-csi/cluster-driver-registrar
0bc9c7d
@bells17
Add link: https://github.com/kubernetes-csi/livenessprobe
09119c1
@bells17
Add link: https://github.com/kubernetes-csi/external-resizer
3e50331
@bells17
Add link: https://github.com/kubernetes-csi/external-provisioner/blob…
45a3d73 
…/master/README.md
@bells17
Add link: https://github.com/kubernetes-csi/external-snapshotter/blob…
019edd2 
…/master/README.md
@k8s-ci-robot k8s-ci-robot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 27, 2019
@bells17 bells17 changed the title Add link: https://github.com/kubernetes-csi/external-attacher/blob/master/README.md Add links Aug 27, 2019
saad-ali
saad-ali approved these changes Aug 27, 2019
View reviewed changes
Copy link
Member

@saad-ali saad-ali left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: bells17, saad-ali

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added lgtm "Looks good to me", indicates that a PR is ready to be merged. approved Indicates a PR has been approved by an approver from all required OWNERS files. release-note-none Denotes a PR that doesn't merit a release note. and removed do-not-merge/release-note-label-needed Indicates that a PR should not merge because it's missing one of the release note labels. labels Aug 27, 2019
@k8s-ci-robot k8s-ci-robot merged commit adaa11d into kubernetes-csi:master Aug 27, 2019
@bells17 bells17 mentioned this pull request Oct 25, 2019
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@saad-ali saad-ali saad-ali approved these changes

@lpabon lpabon Awaiting requested review from lpabon

@msau42 msau42 Awaiting requested review from msau42

Assignees

@saad-ali saad-ali

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. lgtm "Looks good to me", indicates that a PR is ready to be merged. release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@bells17 @k8s-ci-robot @saad-ali