Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate apiserver request latency metric to apiserver_request_sli_duration_seconds #809

Closed
dgrisonnet opened this issue Nov 23, 2022 · 7 comments
Labels

Comments

@dgrisonnet
Copy link
Contributor

In Kubernetes 1.26 we renamed the apiserver_request_slo_duration_seconds metric to apiserver_request_sli_duration_seconds: kubernetes/kubernetes#112679 and we are looking at removing the _slo_ metric in 1.27. As such, the mixins should be updated to use the new metric.

/cc @metalmatze

@metalmatze
Copy link
Member

I wonder if a recording rule could be helpful for the migration. I remember similar things from node-exporter migrations.

@dgrisonnet
Copy link
Contributor Author

Yeah, that could definitely help since it would allow using whichever metric is available.

@dgrisonnet
Copy link
Contributor Author

Thinking about it again, having a recording rule to select one the metrics will introduce these potential problems:

  • without label aggregation, the evaluation will take a lot of time considering the sheer amount of metrics
  • metrics won't be as fresh as they used to be since their freshness will now depend on the evaluation period

Copy link

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Sep 16, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Sep 24, 2024
@metalmatze
Copy link
Member

I believe this is still valid, is it @dgrisonnet?

@metalmatze metalmatze reopened this Oct 9, 2024
@metalmatze metalmatze removed the stale label Oct 9, 2024
@dgrisonnet
Copy link
Contributor Author

I believe you fixed it in #874 no?

Copy link

github-actions bot commented Nov 9, 2024

This issue has not had any activity in the past 30 days, so the
stale label has been added to it.

  • The stale label will be removed if there is new activity
  • The issue will be closed in 7 days if there is no new activity
  • Add the keepalive label to exempt this issue from the stale check action

Thank you for your contributions!

@github-actions github-actions bot added the stale label Nov 9, 2024
@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Nov 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants