This repository has been archived by the owner on Jul 16, 2024. It is now read-only.
Add etcd-manager under etcd-manager/ subdirectory #162
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…p_transport Don't copy http.Transport
We make the transition to TLS explicit, and it is driven by the controller reconciliation loop. If the controller determines that we should be TLS, we update the PeerURL, rewriting http -> https. We do this first in the cluster (through raft), then we restart the etcd process with an RPC request. Lots of testing also!
Use TLS for etcd itself
Update readme for TLS-by-default support
Leads to much faster recovery
Cancel prepare if we fail to expand cluster
…s_to_grid Add more tests to our grid
We don't want to assume that the controller works for newer etcd versions.
…if_we_dont_support Don't act as leader for unknown etcd version
Added a few places where I forgot this - mostly tests, but also some backup code paths.
…clients Don't forget to call client.Close()
Tests: tolerate TLS bounce
Not all paths are supported (e.g. downgrades don't work), so we have a "safe list" of transitions that are safe.
…ades Support in-place upgrades from v3 -> v3
…failures travis: show output from failed tests only
The logic was too strict - it failed if we restarted etcd (as we do when enabling TLS).
…ady_logic Tests: fix wait-for-ready logic
Includes some important crypto fixes
…_1_11_6 Build with go 1.11.6
We sync up with the etcd release version to avoid confusion.
Mark release v3
We include /rootfs and symlink dereferencing. This allows recognizing mounted devices on CentOS on GCE.
…ymlinks Detect more aliases for devices
justinsb
force-pushed
the
add_etcd_manager
branch
2 times, most recently
from
926bedf
to
7b4269f
Compare
|
I cracked the code @dlipovetsky - clabot is happy :-) |
k8s-ci-robot
added
cncf-cla: yes
…plication-credentials Adds support for using OS application credentials
…auth-swift Fixes usage of OpenStack Swift reauthentication
…n-base Move from debian-hyperkube-base to debian-base
Add license headers to each file
Fix some typos picked up by verify-spelling
justinsb
force-pushed
the
add_etcd_manager
branch
from
7b4269f
to
563c830
Compare
k8s-ci-robot
added
the
do-not-merge/invalid-commit-message
justinsb
force-pushed
the
add_etcd_manager
branch
2 times, most recently
from
2397769
to
b791c4d
Compare
k8s-ci-robot
removed
the
do-not-merge/invalid-commit-message
Blocking merge to etcdadm.
Fix some problems with trailing spaces
justinsb
force-pushed
the
add_etcd_manager
branch
from
b791c4d
to
4a14b24
Compare
justinsb
force-pushed
the
add_etcd_manager
branch
from
4a14b24
to
2591372
Compare
|
@dlipovetsky I think this is green (with a few exclusions, admittedly!) |
|
😆 Thank you for seeing this through, @justinsb! /lgtm |
k8s-ci-robot
added
the
lgtm
|
I wonder why there are rebase conflicts... |
|
I think/hope the rebase conflicts were from before I figured out the correct procedure! If not I guess it won't merge, so .... /hold cancel |
k8s-ci-robot
removed
the
do-not-merge/hold
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As discussed in office hours, adding etcd-manager in a subdirectory to enable the projects to converge.