Skip to content
This repository has been archived by the owner on Apr 25, 2023. It is now read-only.

pre-commit script fails on macOS #1304

Closed
makkes opened this issue Oct 20, 2020 · 1 comment
Closed

pre-commit script fails on macOS #1304

makkes opened this issue Oct 20, 2020 · 1 comment
Labels
kind/bug Categorizes issue or PR as related to a bug.

Comments

@makkes
Copy link
Contributor

makkes commented Oct 20, 2020

What happened:
on macOS, the scripts/pre-commit.sh doesn't work:

[...]
Configuring container registry on host
Password:
./scripts/create-clusters.sh: line 76: 3: unbound variable

What you expected to happen:
pre-commit runs and returns successfully (exit code 0).

How to reproduce it (as minimally and precisely as possible):
on macOS, run:

DOWNLOAD_BINARIES=y bash -x ./scripts/pre-commit.sh

Anything else we need to know?:

Environment:

  • Kubernetes version (use kubectl version)
  • KubeFed version
  • Scope of installation (namespaced or cluster)
  • Others

/kind bug

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Oct 20, 2020
@makkes
Copy link
Contributor Author

makkes commented Dec 10, 2020

Doesn't happen, anymore.

@makkes makkes closed this as completed Dec 10, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/bug Categorizes issue or PR as related to a bug.
Projects
None yet
Development

No branches or pull requests

2 participants