Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Proposal: Flag to adopt resources #86

Closed
barney-s opened this issue Jan 31, 2019 · 2 comments · Fixed by #87
Closed

Proposal: Flag to adopt resources #86

barney-s opened this issue Jan 31, 2019 · 2 comments · Fixed by #87

Comments

@barney-s
Copy link
Contributor

barney-s commented Jan 31, 2019 •
edited
Loading

Proposal is for adopting resources that match the AppCRD selectors.

# Flag that indicates matched resources must be adopted
.spec.adopt: true

In some use cases where application crd is used, the tooling explicitly sets OwnerReference of the objects (that match appcrd selectors) to point to the Application object.

Can we make this automatic controller by a flag that is turned off by default.
@barney-s
Copy link
Contributor Author

@kow3ns @huyhg FYI

@barney-s barney-s mentioned this issue Feb 2, 2019
Merged
@ant31
Copy link
Contributor

ant31 commented Feb 4, 2019

related to #7

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add 'addOwnerRef' flag to the spec. barney-s/application
2 participants
@ant31 @barney-s