Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

efs startpuptaint not works correctly #1273

Closed
Mieszko96 opened this issue Feb 20, 2024 · 4 comments
Closed

efs startpuptaint not works correctly #1273

Mieszko96 opened this issue Feb 20, 2024 · 4 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.

Comments

@Mieszko96
Copy link

/kind bug

What happened?
i saw new feature was requested in this ticket
#1069

I have infrastructure with karpenter as autoscale tool. And we have problem with installing apps using EFS on brand new node.
I added startupTaint to prevent it, but from my POV it looks like is deleting this taint to fast

i made some more steps how i testing this in karpenter ticket aws/karpenter-provider-aws#5691

but it seems to be a problem on EFS side.

What you expected to happen?

How to reproduce it (as minimally and precisely as possible)?

Anything else we need to know?:

Environment

  • Kubernetes version 1.2.7
  • Driver version: 2.5.5 helmchart

Please also attach debug logs to help us better diagnose

  • Instructions to gather debug logs can be found here
@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Feb 20, 2024
@steved
Copy link
Contributor

steved commented Mar 26, 2024

I ran into this as well. It looks like the EBS driver may not be encountering this because of some delays added: kubernetes-sigs/aws-ebs-csi-driver#1949.

Specifically, I see eks:node-manager tainting the node after the driver has started:

I0326 02:14:25.282728       1 round_trippers.go:463] GET https://172.20.0.1:443/api/v1/nodes/ip-10-0-39-238.us-west-2.compute.internal
I0326 02:14:25.282736       1 round_trippers.go:469] Request Headers:
I0326 02:14:25.282742       1 round_trippers.go:473]     Accept: application/json, */*
I0326 02:14:25.282747       1 round_trippers.go:473]     User-Agent: aws-efs-csi-driver/v0.0.0 (linux/amd64) kubernetes/$Format
I0326 02:14:25.282753       1 round_trippers.go:473]     Authorization: Bearer <masked>
I0326 02:14:25.298894       1 round_trippers.go:574] Response Status: 200 OK in 16 milliseconds
I0326 02:14:25.299687       1 node.go:486] "No taints to remove on node, skipping taint removal"
I0326 02:14:25.299702       1 driver.go:137] Listening for connections on address: &net.UnixAddr{Name:"/csi/csi.sock", Net:"unix"}
I0326 02:14:28.015603       1 node.go:311] NodeGetInfo: called with args
$ jq -r '.[0]["@message"] | .user.username, .objectRef, .requestObject, .requestReceivedTimestamp' logs-insights-results.json
eks:node-manager
{
  "resource": "nodes",
  "name": "ip-10-0-39-238.us-west-2.compute.internal",
  "apiVersion": "v1"
}
{
  "spec": {
    "taints": [
      {
        "effect": "NoExecute",
        "key": "efs.csi.aws.com/agent-not-ready",
        "value": "true"
      },
      {
        "effect": "NoExecute",
        "key": "ebs.csi.aws.com/agent-not-ready",
        "value": "true"
      }
    ]
  }
}
2024-03-26T02:14:31.296272Z

@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle stale
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 24, 2024
@k8s-triage-robot
Copy link

The Kubernetes project currently lacks enough active contributors to adequately respond to all issues.

This bot triages un-triaged issues according to the following rules:

  • After 90d of inactivity, lifecycle/stale is applied
  • After 30d of inactivity since lifecycle/stale was applied, lifecycle/rotten is applied
  • After 30d of inactivity since lifecycle/rotten was applied, the issue is closed

You can:

  • Mark this issue as fresh with /remove-lifecycle rotten
  • Close this issue with /close
  • Offer to help out with Issue Triage

Please send feedback to sig-contributor-experience at kubernetes/community.

/lifecycle rotten

@k8s-ci-robot k8s-ci-robot added lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed. and removed lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. labels Jul 24, 2024
@mskanth972
Copy link
Contributor

We released a new version(2.0.6) which has the Fix to GitHub and related PR. ECD for the Addons will be 07/31.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/rotten Denotes an issue or PR that has aged beyond stale and will be auto-closed.
Projects
None yet
Development

No branches or pull requests

5 participants