Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to create multiple storage classes with Helm chart #387

Closed
NilsGriebner opened this issue Mar 23, 2021 · 2 comments
Closed

Unable to create multiple storage classes with Helm chart #387

NilsGriebner opened this issue Mar 23, 2021 · 2 comments
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.

Comments

@NilsGriebner
Copy link
Contributor

/kind bug

What happened?
If multiple storageclasses are specified in values.yaml like

storageClasses:
  - name: efs-sc1
    parameters:
      provisioningMode: efs-ap
      fileSystemId: 123
      directoryPerms: "700"
  - name: efs-sc2
    parameters:
      provisioningMode: efs-ap
      fileSystemId: 345
      directoryPerms: "700"

the generated output lacks yaml separators. In my case the outcome was

...
---
# Source: aws-efs-csi-driver/templates/storageclass.yaml
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc1
provisioner: efs.csi.aws.com
parameters:
  directoryPerms: "700"
  fileSystemId: 123
  provisioningMode: efs-ap
kind: StorageClass
apiVersion: storage.k8s.io/v1
metadata:
  name: efs-sc2
provisioner: efs.csi.aws.com
parameters:
  directoryPerms: "700"
  fileSystemId: 345
  provisioningMode: efs-ap
---
...

What you expected to happen?
I expect two storageclasses to be created but only the last one gets created

How to reproduce it (as minimally and precisely as possible)?
Put my provided example code from values.yaml into the default values and run helm install ...

Anything else we need to know?:
No

Environment

  • Kubernetes version (use kubectl version):
    v1.18.9-eks-d1db3c

  • Driver version:
    1.2.0

@k8s-ci-robot k8s-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Mar 23, 2021
@fejta-bot
Copy link

Issues go stale after 90d of inactivity.
Mark the issue as fresh with /remove-lifecycle stale.
Stale issues rot after an additional 30d of inactivity and eventually close.

If this issue is safe to close now please do so with /close.

Send feedback to sig-contributor-experience at kubernetes/community.
/lifecycle stale

@k8s-ci-robot k8s-ci-robot added the lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale. label Jun 21, 2021
@wongma7
Copy link
Contributor

wongma7 commented Jun 21, 2021

#388

@wongma7 wongma7 closed this as completed Jun 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Categorizes issue or PR as related to a bug. lifecycle/stale Denotes an issue or PR has remained open with no activity and has become stale.
Projects
None yet
Development

No branches or pull requests

4 participants